Skip to content

Conversation

@alexwolfmsft
Copy link
Contributor

@alexwolfmsft alexwolfmsft commented Jan 14, 2025

Summary

Describe your changes here.

Fixes #Issue_Number (if available)


Internal previews

📄 File 🔗 Preview link
docs/azure/sdk/authentication/authentication-best-practices.md Authentication best practices with the Azure Identity library for .NET
docs/azure/TOC.yml docs/azure/TOC

Co-authored-by: Christopher Scott <[email protected]>
@alexwolfmsft alexwolfmsft marked this pull request as ready for review January 15, 2025 21:18
@alexwolfmsft alexwolfmsft requested review from a team, CamSoper, jsquire and schaabs as code owners January 15, 2025 21:18
Copy link
Contributor

@christothes christothes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple minor suggestions, but overall LGTM!

Copy link
Member

@scottaddie scottaddie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after incorporating Chris' suggestions!

Co-authored-by: Christopher Scott <[email protected]>
@alexwolfmsft alexwolfmsft merged commit 1c007f0 into dotnet:main Jan 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants